-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient2Limit fixes #134
base: main
Are you sure you want to change the base?
Gradient2Limit fixes #134
Conversation
@elandau could you please take a look at this? |
hi, bro, did u meet this situtation in issue #137 ? |
@happyomg afaict, drop translates to back-pressure from the downstream service. In that case, using 0.5 as gradient is probably not a bad idea. 0.5 aligns with other limiters like AIMD in this repo. Remember that there is a smoothing factor to absorb any intermittent shocks. |
@elandau do you have an estimate on when you would be able to review this? I am waiting on this since 8 days. |
@elandau In case you are waiting for the travis failure fix, the failure seems to be a transient one. |
When we have a high limit, we skip adjusting the limit even when requests start taking longer times to finish.
No description provided.